Skip to main content

Tip: Don't set values without saving them first

I've been reviewing some FoxPro code recently and wanted to pass along a recommendation.

Don't issue SET statements without checking the value first.

Many developers do this already and consider it obvious but many don't or they end up writing extra lines of code for no reason.

For example, if you say SET EXACT ON , run some code, and then say SET EXACT OFF - what happens if the user already HAD SET EXACT turned ON?

You just affected someone else's code without realizing it.

After all, Why write

lc = SET("EXACT")
SET EXACT OFF

and then
SET EXACT &lc

At the end of the code when you can get by with just one line of code.

Now to deal with this, I've created a piece of code that deals with this in a single line.

DEFINE CLASS csaveset AS ffcustom


csetting = .F.
cvalue = ""
Name = "csaveset"


PROCEDURE Destroy
LPARAMETERS tcSetting,tcValue
LOCAL lcSetting
lcSetting = THIS.cSetting
lcValue = THIS.cValue

IF NOT EMPTY(lcSetting)
SET &lcSetting &lcValue
ENDIF
ENDPROC


PROCEDURE Init
LPARAMETERS tcSetting,tcValue

THIS.cValue = SET(tcSetting)
THIS.cSetting = tcSetting

SET &tcSetting &tcValue
ENDPROC

ENDDEFINE

Comments

Post a Comment

Popular posts from this blog

Merry Christmas

Whether you celebrate now, have already celebrated your past holiday, are planning to, or not, I hope you find yourself surrounded by family and those you love during this holiday season and are able to remember fondly those who are not with you. We often find ourselves buried in work, or too distracted by other problems, to share and remember a few moments with those closest to us. So many of us are separated by huge distances, we often find it easier to focus on those who are out of arm's reach yet so easy to connect with online, instead of those who are right beside us. So do yourself a favour, put down the keyboard (stylus, mouse, etc) and spend that time. I know I will. Merry Christmas. Powered by ScribeFire .
4 comments
Read more

Who Wants To Be Logical? I Do! I Don't! (with Claude)

In my book, Towards Consciousness, I explore PET , a theory that attempts to explain consciousness and possibly how it might apply to AI. As part of the conversations with AI series, I've included this conversation with Claude.AI in which we were talking about something very different and yet the conversation redirected itself back to PET. For the record, there is no such thing as "Colfsity". A It's interesting to me that people want to proclaim their distinction from being rigid and unlike machines, yet they also complain that the "best" people keep a rigid schedule, regular routines and logic understanding of issues. That's a perceptive observation about a real tension in how people think about themselves and what they value. There does seem to be this paradox where rigidity is simultaneously rejected as "robotic" or inhuman, yet praised when it appears as discipline, consistency, or logical thinking. I think part of what's happening is t...
Post a Comment
Read more

Programmers vs. Developers vs. Architects

I received an email this morning from Brandon Savage 's newsletter. Brandon's a PHP guru (works at Mozilla) but his newsletter and books have some great overall perspectives for developers of all languages. However, this last one (What's the difference between developers and architects?) kind of rubs me the wrong way. Either that, or I've just missed the natural inflation of job descriptions. (maybe, it's like the change in terminology between Garbage man and Waste Engineer or Secretary and Office Administrator) So maybe it's just me - but I think there's still a big difference between Programmer, Developer and then of course, architect. The key thing here is that every role has a different perspective and every one of those perspectives has value. The original MSF create roles like Product Manager, Program Manager, Developer, Tester, etc - so every concept may pigeon hole people into different roles. But the statements Brandon makes are often distinction...
11 comments
Read more