Skip to main content

Tip: Don't set values without saving them first

I've been reviewing some FoxPro code recently and wanted to pass along a recommendation.

Don't issue SET statements without checking the value first.

Many developers do this already and consider it obvious but many don't or they end up writing extra lines of code for no reason.

For example, if you say SET EXACT ON , run some code, and then say SET EXACT OFF - what happens if the user already HAD SET EXACT turned ON?

You just affected someone else's code without realizing it.

After all, Why write

lc = SET("EXACT")
SET EXACT OFF

and then
SET EXACT &lc

At the end of the code when you can get by with just one line of code.

Now to deal with this, I've created a piece of code that deals with this in a single line.

DEFINE CLASS csaveset AS ffcustom


csetting = .F.
cvalue = ""
Name = "csaveset"


PROCEDURE Destroy
LPARAMETERS tcSetting,tcValue
LOCAL lcSetting
lcSetting = THIS.cSetting
lcValue = THIS.cValue

IF NOT EMPTY(lcSetting)
SET &lcSetting &lcValue
ENDIF
ENDPROC


PROCEDURE Init
LPARAMETERS tcSetting,tcValue

THIS.cValue = SET(tcSetting)
THIS.cSetting = tcSetting

SET &tcSetting &tcValue
ENDPROC

ENDDEFINE

Comments

Popular posts from this blog

FoxInCloud Stats

FoxInCloud sent this link a while back about their statistics regarding visits to their site: http://foxincloud.com/blog/2017/12/27/VFP-community-lessons-from-foxincloud-site.html What's interesting here is the breakdown of people. Yes, I think it's understandable that the Fox community is getting older. Another factor is the growth of the mobile and web environments taking over development. These environments really do push people towards the newer non-SQL or free SQL/hosted environments but more towards hosted storage options like Amazon and Google. A tool like FoxInCloud that helps MOVE existing applications to the cloud inherently competes with those environments. But FoxInCloud also allows developers to extend their application further by giving them a starting point using Javascript and the basic CSS (such as Bootstrap). If you're not rebuilding your application from scratch, it's certainly a great step forward. FoxPro VFP

Blogs and RSS come to Microsoft.com

MS has just introduced their portal and it's pretty comprehensive. Nothing quite like learning that some people use AIM instead of MSN messenger, or that there really may be a need for supporting 4 monitors ( Cyrus Complains ) However, it's really a great sign that MS is serious about supporting the blogging community which seems to have um, exploded in size in the past year. Blogs and RSS come to Microsoft.com