Skip to main content

Doing Code Reviews with Code Analyst

I mentioned earlier that I was at a developer strategy meeting last week (n fact, Markus was there too) - of course, I wasn't traveling at the time. One of the comments from that meeting was how it's very hard (read, impossible) to stick to manual code reviews. Code reviews are a great practice and certainly valuable but when push comes to shove, it's often one of the practices that seem to slip away in favor of getting things done.

Now, in Team System, you can set up all kinds of rules for checking code in to help manage this process but what can you do in FoxPro?

One idea that came to me was extending the VFPX Code Analyst tool to become "project" or "environment" specific. Yes, you can create a number of new rules to run within the code analyst and enable/disable them as needed but what would also be useful would be to allow different projects to have "different" sets of rules that they might apply to. Then set up a project hook so that when you BUILD the project, the rules automatically run, telling you what's good and what's bad.

In this sense, you now have an automated "code review" tool.

The default rules in Code Analyst handle a number of generic pieces like identifying areas for refactoring, or finding known gotchas like RETURNs within ENDWITH, similar lines of code, but consider project-specific types of rules: ensuring classes are based on a common class library, appropriate use of MESSAGEBOX, no compilation errors, etc - and the tool takes on a whole new benefit.

This is one of those things that I'm going to add to the "to do" list for the Code Analyst: built-in project hooks, and some useful project rules.

What type of rules would you want to see in your code?

VFPX - Home

Powered by ScribeFire.

Comments

VfpImaging said…
Hi Andrew,

Using the Project Hook is indeed a great idea.

Here are my suggestions:

Check on every event's method if there is either a NODEFAULT or a DODEFAULT() present.

Check for undeclared variables.

Thanks, and keep your great job !

Regards

Cesar
June 29, 2007 at 4:30 PM
Post a Comment

Popular posts from this blog

Merry Christmas

Whether you celebrate now, have already celebrated your past holiday, are planning to, or not, I hope you find yourself surrounded by family and those you love during this holiday season and are able to remember fondly those who are not with you. We often find ourselves buried in work, or too distracted by other problems, to share and remember a few moments with those closest to us. So many of us are separated by huge distances, we often find it easier to focus on those who are out of arm's reach yet so easy to connect with online, instead of those who are right beside us. So do yourself a favour, put down the keyboard (stylus, mouse, etc) and spend that time. I know I will. Merry Christmas. Powered by ScribeFire .
4 comments
Read more

Programmers vs. Developers vs. Architects

I received an email this morning from Brandon Savage 's newsletter. Brandon's a PHP guru (works at Mozilla) but his newsletter and books have some great overall perspectives for developers of all languages. However, this last one (What's the difference between developers and architects?) kind of rubs me the wrong way. Either that, or I've just missed the natural inflation of job descriptions. (maybe, it's like the change in terminology between Garbage man and Waste Engineer or Secretary and Office Administrator) So maybe it's just me - but I think there's still a big difference between Programmer, Developer and then of course, architect. The key thing here is that every role has a different perspective and every one of those perspectives has value. The original MSF create roles like Product Manager, Program Manager, Developer, Tester, etc - so every concept may pigeon hole people into different roles. But the statements Brandon makes are often distinction...
11 comments
Read more

From Writing to AI: the pattern repeats itself

When I was ten years old, my dad bought a computer and, thanks to an advertising supplement in a Superman comic I read, it was a TRS-80. A month later, he dragged the entire family (my mom and brother were not the most enthusiastic) to a class at Radio Shack teaching how to use microcomputers. At the time, I understood why my mom wasn’t that excited: the computer was yet another gadget in the house. But today I find it fascinating. My mother went to Vassar in the 50s. She learned how to type — not a common skill at the time — but it opened doors. Her ability to communicate effectively led her to a career in adult education and later communications work with the CBC (Canadian Broadcasting Corporation). This isn’t a nostalgia post. Today, the ability to use artificial intelligence, be it through Copilot or simply writing the right prompt, is becoming a critical skill. But is it really that novel? In the 1500s and 1600s, the printing press gradually made reading accessible beyond cler...
Post a Comment
Read more